feat: 邮箱冲突检测优化 v1.1.1
- 新增邮箱冲突检测:发送验证码前检查邮箱是否已被注册 - 优化用户体验:避免向已注册邮箱发送无用验证码 - 改进错误处理:返回409 Conflict状态码和明确错误信息 - 更新API文档:重新整理文档结构,突出前端开发要点 - 完善测试用例:添加邮箱冲突检测相关测试 - 版本升级:1.1.0 1.1.1 核心修改: - src/core/login_core/login_core.service.ts: 在sendEmailVerification方法中添加邮箱存在性检查 - src/business/auth/controllers/login.controller.ts: 正确处理409冲突状态码 - docs/api/api-documentation.md: 重新整理为精简实用的前端开发文档 - docs/api/openapi.yaml: 更新版本和接口描述 - test-register-fix.ps1: 添加邮箱冲突检测测试用例
This commit is contained in:
@@ -6,11 +6,14 @@
|
||||
# 2. 用户注册(有邮箱但无验证码)- 应该失败并返回正确错误信息
|
||||
# 3. 用户存在性检查 - 应该在验证码验证之前进行,返回"用户名已存在"
|
||||
# 4. 邮箱验证码完整流程 - 验证码生成、注册、重复邮箱检查
|
||||
# 5. 邮箱冲突检测 - 发送验证码前检查邮箱是否已注册
|
||||
#
|
||||
# 修复验证:
|
||||
# - 用户存在检查现在在验证码验证之前执行
|
||||
# - 邮箱冲突检测防止向已注册邮箱发送验证码
|
||||
# - 验证码不会因为用户已存在而被无效消费
|
||||
# - 错误信息更加准确和用户友好
|
||||
# - 返回正确的HTTP状态码(409 Conflict)
|
||||
$baseUrl = "http://localhost:3000"
|
||||
|
||||
Write-Host "🧪 Testing Register API Fix" -ForegroundColor Green
|
||||
@@ -100,25 +103,42 @@ if ($result1 -and $result1.success) {
|
||||
}
|
||||
}
|
||||
|
||||
# Test 4: Get verification code and register with email
|
||||
Write-Host "`n📋 Get verification code and register with email" -ForegroundColor Yellow
|
||||
# Test 4: Email conflict detection test
|
||||
Write-Host "`n📋 Email conflict detection test" -ForegroundColor Yellow
|
||||
try {
|
||||
$emailResponse = Invoke-RestMethod -Uri "$baseUrl/auth/send-email-verification" -Method POST -Body (@{email = "newuser@test.com"} | ConvertTo-Json) -ContentType "application/json"
|
||||
# First, try to get verification code for a new email
|
||||
$newEmail = "newuser_$(Get-Random)@test.com"
|
||||
$emailResponse = Invoke-RestMethod -Uri "$baseUrl/auth/send-email-verification" -Method POST -Body (@{email = $newEmail} | ConvertTo-Json) -ContentType "application/json"
|
||||
|
||||
if ($emailResponse.data.verification_code) {
|
||||
$verificationCode = $emailResponse.data.verification_code
|
||||
Write-Host "Got verification code: $verificationCode" -ForegroundColor Green
|
||||
|
||||
# Register user with this email
|
||||
$result4 = Test-ApiCall -TestName "Register with valid email and verification code" -Url "$baseUrl/auth/register" -Body (@{
|
||||
username = "emailuser_$(Get-Random)"
|
||||
password = "password123"
|
||||
nickname = "Email User"
|
||||
email = "newuser@test.com"
|
||||
email = $newEmail
|
||||
email_verification_code = $verificationCode
|
||||
} | ConvertTo-Json)
|
||||
|
||||
if ($result4 -and $result4.success) {
|
||||
Write-Host "✅ PASS: Email registration successful" -ForegroundColor Green
|
||||
|
||||
# Now test email conflict detection
|
||||
Write-Host "`n📋 Testing email conflict detection" -ForegroundColor Yellow
|
||||
try {
|
||||
$conflictResponse = Invoke-RestMethod -Uri "$baseUrl/auth/send-email-verification" -Method POST -Body (@{email = $newEmail} | ConvertTo-Json) -ContentType "application/json"
|
||||
Write-Host "❌ FAIL: Should have detected email conflict" -ForegroundColor Red
|
||||
} catch {
|
||||
$statusCode = $_.Exception.Response.StatusCode.value__
|
||||
if ($statusCode -eq 409) {
|
||||
Write-Host "✅ PASS: Email conflict detected (409 status)" -ForegroundColor Green
|
||||
} else {
|
||||
Write-Host "❌ FAIL: Wrong status code for email conflict ($statusCode)" -ForegroundColor Red
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
} catch {
|
||||
@@ -129,5 +149,7 @@ Write-Host "`n🎯 Test Summary" -ForegroundColor Green
|
||||
Write-Host "===============" -ForegroundColor Green
|
||||
Write-Host "✅ Registration logic has been fixed:" -ForegroundColor White
|
||||
Write-Host " • User existence checked BEFORE verification code validation" -ForegroundColor White
|
||||
Write-Host " • Email conflict detection prevents sending codes to registered emails" -ForegroundColor White
|
||||
Write-Host " • Proper error messages for different scenarios" -ForegroundColor White
|
||||
Write-Host " • Verification codes not wasted on existing users" -ForegroundColor White
|
||||
Write-Host " • Verification codes not wasted on existing users" -ForegroundColor White
|
||||
Write-Host " • Returns 409 Conflict for email/username conflicts" -ForegroundColor White
|
||||
Reference in New Issue
Block a user